linux-kernel - Re: [PATCH] drivers/usb/core: hcd.c: Removed all space warnings from checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1428769196.5413.55.camel@perches.com>
Date:	Sat, 11 Apr 2015 09:19:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Chase Metzger <chasemetzger15@...il.com>
Cc:	gregkh@...uxfoundation.org, stern@...land.harvard.edu,
	balbi@...com, dan.j.williams@...el.com,
	antoine.tenart@...e-electrons.com, pmladek@...e.cz,
	sojka@...ica.cz, xerofoify@...il.com,
	sergei.shtylyov@...entembedded.com, rafael.j.wysocki@...el.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/core: hcd.c: Removed all space warnings
 from checkpatch.pl

On Sat, 2015-04-11 at 03:04 -0700, Chase Metzger wrote:
> Removed all(except false positives, from calculations) space prohibited warnings generated by
> checkpatch.pl.

False positives?  Please describe them.

The only thing I believe you elided was the
use of a BitTime macro which in my opinion
should be used as a function.

drivers/usb/core/hcd.c:                 tmp = (67667L * (31L + 10L * BitTime (bytecount))) / 1000L;

as it is in the include file:

include/linux/usb/hcd.h:        + (2083UL * (3 + BitTime(bytes))))/1000 \


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/