linux-kernel - Re: i_uid_read()/i_uid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d23bz4y3.fsf@x220.int.ebiederm.org>
Date:	Fri, 10 Apr 2015 23:04:04 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Anton Altaparmakov <anton@...era.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: i_uid_read()/i_uid_write() and friends

Anton Altaparmakov <anton@...era.com> writes:

> Hi,
>
> Is it intended that non-gpl file systems cannot use functions like
> i_uid_read() and i_uid_write() (introduced by Eric Biederman in 3.5
> kernel)?
>
> They resolve to the below (in include/linux/fs.h):
>
> static inline uid_t i_uid_read(const struct inode *inode)
> {
>         return from_kuid(&init_user_ns, inode->i_uid);
> }
>
> static inline void i_uid_write(struct inode *inode, uid_t uid)
> {
>         inode->i_uid = make_kuid(&init_user_ns, uid);
> }
>
> And both from_kuid() and make_kuid() are EXPORT_SYMBOL() so they are
> fine but the problem is that init_user_ns is EXPORT_SYMBOL_GPL() and
> because i_uid_read() and i_uid_write() are static inline it causes
> them to be unusable from non-gpl kernel modules...
>
> Same thing applies to i_gid_read() and i_gid_write().
>
> These seem pretty fundamental calls that a non-gpl file system should
> be able to call, no?

I believe you are asking should a deriviative work of a GPL'd piece of
software be licenseable under something other than the GPL.  I don't see
any provision in the GPLv2 for such a thing.

I am pretty certain that kuid_t is unique to the linux kernel and any
use of it makes your software a derivative work.

All EXPORT_SYMBOL_GPL does is provide a hint that the author could not
imagine that you could possibly use it in something that was not a
derivative work.  EXPORT_SYMBOL makes no comment whatsoever.

As long as you are complying with the license of the kernel I don't see
how the question of a non-gpl file system can make any sense.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/