linux-kernel - Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANUX_P36HE+efTSvVYV5tYC01vNzoQKcLVECsH7QJXHPGirYdw@mail.gmail.com>
Date:	Sun, 12 Apr 2015 20:37:29 +0300
From:	Emmanuel Grumbach <egrumbach@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote:
>> Every tracing file must have its own TRACE_SYSTEM defined.
>> The iwlwifi tracepoint header broke this and added in the middle
>> of the file:
> [...]
>> Unfortunately, this broke new code in the ftrace infrastructure.
>> Moving each of these TRACE_SYSTEMs into their own trace file with
>> just one TRACE_SYSTEM per file fixes the issue.
>>
>> Cc: Johannes Berg <johannes@...solutions.net>
>> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
>
>
>>  drivers/net/wireless/iwlwifi/iwl-devtrace-data.h   |  79 ++++
>>  drivers/net/wireless/iwlwifi/iwl-devtrace-io.h     | 155 ++++++++
>>  .../net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h    | 200 ++++++++++
>>  drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h    |  97 +++++
>>  drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h  |  81 ++++
>>  drivers/net/wireless/iwlwifi/iwl-devtrace.h        | 438 +--------------------
>>  6 files changed, 618 insertions(+), 432 deletions(-)
>>  create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-data.h
>>  create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-io.h
>>  create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-iwlwifi.h
>>  create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-msg.h
>>  create mode 100644 drivers/net/wireless/iwlwifi/iwl-devtrace-ucode.h
>
> Looks good to me.
>
> Reviewed-by: Johannes Berg <johannes@...solutions.net>
>

I had to make quite a few modifications since this patch was not based
on iwlwifi-next, but I picked it up in our internal tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/