linux-kernel - Re: [PATCH] x86/power/hibernate: Use local labels in asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1683783.5ci0mLlA9Y@vostro.rjw.lan>
Date:	Mon, 13 Apr 2015 01:06:38 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH] x86/power/hibernate: Use local labels in asm

On Sunday, April 12, 2015 09:45:06 PM Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> ... so that they don't appear in the object file and thus in objdump
> output. They're local anyway and have a meaning only within that file.
> 
> No functionality change.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: linux-pm@...r.kernel.org

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  arch/x86/power/hibernate_asm_64.S | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/power/hibernate_asm_64.S b/arch/x86/power/hibernate_asm_64.S
> index 3c4469a7a929..e2386cb4e0c3 100644
> --- a/arch/x86/power/hibernate_asm_64.S
> +++ b/arch/x86/power/hibernate_asm_64.S
> @@ -78,9 +78,9 @@ ENTRY(restore_image)
>  
>  	/* code below has been relocated to a safe page */
>  ENTRY(core_restore_code)
> -loop:
> +.Lloop:
>  	testq	%rdx, %rdx
> -	jz	done
> +	jz	.Ldone
>  
>  	/* get addresses from the pbe and copy the page */
>  	movq	pbe_address(%rdx), %rsi
> @@ -91,8 +91,8 @@ loop:
>  
>  	/* progress to the next pbe */
>  	movq	pbe_next(%rdx), %rdx
> -	jmp	loop
> -done:
> +	jmp	.Lloop
> +.Ldone:
>  	/* jump to the restore_registers address from the image header */
>  	jmpq	*%rax
>  	/*
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/