linux-kernel - Re: [PATCH 3/3] arm64: dts: Add dts files for Hisilicon Hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a9107efdfe64b0d9e9d93421595badb@www.loen.fr>
Date:	Sun, 12 Apr 2015 11:57:35 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Brent Wang <wangbintian@...il.com>
Cc:	Mark Rutland <mark.rutland@....com>, <dan.zhao@...ilicon.com>,
	<btw@...l.itp.ac.cn>, Catalin Marinas <catalin.marinas@....com>,
	<wangbinghui@...ilicon.com>, Will Deacon <will.deacon@....com>,
	<huxinwei@...wei.com>, <khilman@...aro.org>,
	<haojian.zhuang@...aro.org>, <yanhaifeng@...il.com>,
	<rob.herring@...aro.org>, <mturquette@...aro.org>,
	<victor.lixin@...ilicon.com>, <xuwei5@...ilicon.com>,
	<jh80.chung@...sung.com>, <sledge.yanwei@...wei.com>,
	<kong.kongxinwei@...ilicon.com>, <heyunlei@...wei.com>,
	<w.f@...wei.com>, <zhangfei.gao@...aro.org>,
	<z.liuxinliang@...wei.com>, <devicetree@...r.kernel.org>,
	Bintian Wang <bintian.wang@...wei.com>,
	Pawel Moll <pawel.moll@....com>,
	<ijc+devicetree@...lion.org.uk>, <puck.chen@...ilicon.com>,
	<olof@...om.net>, <robh+dt@...nel.org>, <linux@....linux.org.uk>,
	<zhenwei.wang@...ilicon.com>,
	<linux-arm-kernel@...ts.infradead.org>, <guodong.xu@...aro.org>,
	<tomeu.vizoso@...labora.com>, <sboyd@...eaurora.org>,
	<linux-kernel@...r.kernel.org>, <galak@...eaurora.org>,
	<xuejiancheng@...wei.com>, <xuyiping@...ilicon.com>,
	<liguozhu@...ilicon.com>
Subject: Re: [PATCH 3/3] arm64: dts: Add dts files for Hisilicon Hi6220 SoC

On 2015-04-12 07:40, Brent Wang wrote:
> Hello Mark,
>
> 2015-02-06 16:42 GMT+08:00 Brent Wang <wangbintian@...il.com>:
> [...]
>>>
>>>> +     gic: interrupt-controller@...00000 {
>>>> +             compatible = "arm,gic-400", "arm,cortex-a15-gic";
>>>
>>> Surely there's no need for the "arm,cortex-a15-gic" fallback entry? 
>>> What
>>> am I missing?
>> Remove it in next version.
> After remove "arm,cortex-a15-gic", I get the following error during
> kernel booting:
> -----
> kvm [1]: Using HYP init bounce page @396d9000
> kvm [1]: error: no compatible GIC node found
> kvm [1]: error initializing Hyp mode: -19
> -----
>
> Check code "virt/kvm/arm/vgic.c", gicv2 only "cortex-a15-gic" and
> gicv3 support kvm now,
> so I think we should keep it, how about your idea?

Please look at commit 0f37247574b3 that is queued for merge in 4.1.
It adds the required compatibility strings to KVM, so Mark is perfectly
right to ask you to drop this "cortex-a15-gic" from your DT.

This DT won't be merged before 4.1 anyway, so there is no point trying
to make it work with older kernels.

Thanks,

         M.
-- 
Fast, cheap, reliable. Pick two.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/