linux-kernel - Re: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <44902470-673C-4FFA-9724-1C1B48640775@gmail.com>
Date:	Sun, 12 Apr 2015 23:45:30 +0900
From:	Taewoong Song <treeze.taeung@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	namhyung@...nel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.

Hi, jirka

> On Apr 10, 2015, at 6:31 PM, Jiri Olsa <jolsa@...hat.com> wrote:
> 
> On Thu, Apr 09, 2015 at 11:26:31PM +0900, Taeung Song wrote:
>> This patch consists of adding functions
>> which get, set or remove a specific config variable.
>> For the syntax examples,
>> 
>>    perf config [options] [section.subkey[=value]]
>> 
>>    display all perf config with default values
>>    # perf config
>>    or
>>    # perf config -a | --all
> 
> so this is ^^^ what the previous patch does right?
> 
>> 
>>    display a specific key(section.subkey) and value
>>    # perf config report.queue
>> 
>>    set a specific key and value
>>    # perf config report.queue=100M
>> 
>>    remove a specific key
>>    # perf config -r | --remove report.queue
> 
> haven't checked the code but:
> 
>  [jolsa@...va perf]$ ./perf config krava=true
>  The config variable does not contain a section: krava=true[jolsa@...va perf]$ 
> 
> missing '\n'
> 
> we can set anything now:
>  [jolsa@...va perf]$ ./perf config krava.krava=true
> 
> the restriction for only known keys would need similar stuff like
> for the '-a' option I asked in the previous email right?
> 

Thanks for your review.
I sent a couple of patch again.

1. I modified a commit message of second patch to remove comment about ‘-a’, ‘—all’ option.
2. I added ‘\n’ character when printing some error messages.
3. I added ‘Error: Unknown argument’ message.

But I thought that displaying current config with all possible keys and their default values,
and the restriction for only known keys depending on information of all perf configuration
can be included in next patch. 
Would you mind ?

Thanks,
Taeung--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/