linux-kernel - Re: linux-next: build failure after merge of the xen-tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552B802A.3080709@oracle.com>
Date:	Mon, 13 Apr 2015 16:36:58 +0800
From:	Bob Liu <bob.liu@...cle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Xen Devel <Xen-devel@...ts.xensource.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wei Liu <wei.liu2@...rix.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Paul Durrant <paul.durrant@...rix.com>
Subject: Re: linux-next: build failure after merge of the xen-tip tree

Hi Stephen,

On 04/13/2015 04:09 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the xen-tip tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/char/tpm/xen-tpmfront.c: In function 'setup_ring':
> drivers/char/tpm/xen-tpmfront.c:203:7: warning: passing argument 2 of 'xenbus_grant_ring' makes pointer from integer without a cast
>    rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>         ^
> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
> include/xen/xenbus.h:206:5: note: expected 'void *' but argument is of type 'long unsigned int'
>   int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>       ^
> drivers/char/tpm/xen-tpmfront.c:203:7: error: too few arguments to function 'xenbus_grant_ring'
>    rv = xenbus_grant_ring(dev, virt_to_mfn(priv->shr));
>         ^
> In file included from drivers/char/tpm/xen-tpmfront.c:17:0:
> include/xen/xenbus.h:206:5: note: declared here
>   int xenbus_grant_ring(struct xenbus_device *dev, void *vaddr,
>       ^
>
> Caused by commit 1b1586eeeb8c ("xenbus_client: Extend interface to
> support multi-page ring").
>
> I have used the xen-tip tree from next-20150410 for today.
>

Sorry for this issue, I missed the xentpm-front.c file in that patch.
(Original patch from Wei Liu already included the right modification 
which didn't exist in Paul's.)

Attached patch should fix this build failure.

-- 
Regards,
-Bob

View attachment "0001-xen-tpmfront-fix-build-error.patch" of type "text/x-patch" (1332 bytes)