linux-kernel - Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150413103831.GE6023@sirena.org.uk>
Date:	Mon, 13 Apr 2015 11:38:31 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Jin, Yao" <yao.jin@...ux.intel.com>
Cc:	kbuild test robot <fengguang.wu@...el.com>,
	alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	kbuild-all@...org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

On Mon, Apr 13, 2015 at 09:03:39AM +0800, Jin, Yao wrote:
> The NULL check here is to proivde the protection for current code and
> future potential code. It's possible that in future some code may
> change the pointer ipc->msg and the author may miss the kfree here.

That's not the point - the point is that if it's ever valid to call
kfree() then passing a null pointer in is fine.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)