linux-kernel - Re: [PATCH WIP] parport: add device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150413104219.GA6390@kroah.com>
Date:	Mon, 13 Apr 2015 12:42:19 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH WIP] parport: add device model

On Mon, Apr 13, 2015 at 03:32:44PM +0530, Sudip Mukherjee wrote:
> On Mon, Apr 13, 2015 at 10:43:39AM +0200, Greg KH wrote:
> > On Sat, Apr 11, 2015 at 01:41:34PM +0530, Sudip Mukherjee wrote:
> > > On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote:
> > > > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote:
> <snip>
> > > 
> > > 
> > > I can understand that drivers need to be binded to one device, so
> > > suppose ppdev wants to use parport0, how that binding will be done?
> > 
> > The driver core does the "binding".
> > 
> > > do i need mark the driver in the parport->ddev.driver ?
> > 
> > No, just have the probe function for the ppdev function return 0,
> > meaning it successfully bound to the driver that was passed to it and
> > all will be fine.
> well, I was thinking that instead of having probe for individual
> drivers (then we need to modify all the drivers),

Sorry, you will have to modify all drivers, that's going to be a
requirement.

> i was planning like:
> when the driver calls parport_device_register(), the driver will be
> registered under parport and also a subdevice will be created under the
> particular parport the driver wants to use and both will have the same
> name. The probe of the bus will verify that name comparison and will
> return 0 if the name matches. is this plan ok ?
> and i wanted the binding to happen when the driver calls parport_claim()
> and for that I was thinking of calling device_attach() . is that also ok?

I don't know what parport_claim() does, sorry, but you are going to have
to change all drivers.

I suggest working on adding the new parport bus, and convert one or two
drivers to the new code, to get it working first.  Then you can convert
the other drivers and then delete the old registration code from the
parport core, as it will be not used anymore.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/