[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <552B3C74.9030004@wwwdotorg.org>
Date: Sun, 12 Apr 2015 21:48:04 -0600
From: Stephen Warren <swarren@...dotorg.org>
To: Linus Walleij <linus.walleij@...aro.org>
CC: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
Ray Jui <rjui@...adcom.com>, Lee Jones <lee@...nel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
linux-rpi-kernel@...ts.infradead.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: bcm2835: Fix support for threaded level triggered
IRQs
On 04/08/2015 08:43 AM, Linus Walleij wrote:
> On Tue, Apr 7, 2015 at 12:43 PM, Charles Keepax
> <ckeepax@...nsource.wolfsonmicro.com> wrote:
>
>> Currently, the driver uses handle_simple_irq for all IRQ types and hard
>> codes the acknowledge for different IRQ types into the handler. It is
>> better to use the IRQ core as intended and let it handle the differences
>> between the various types of IRQ. For example the current system does
>> not work for threaded level triggered IRQs as these need to be masked
>> until the threaded handler has run.
>>
>> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
>
> Looks like a very fine patch so applied unless Stephen has
> some problem with it.
This patch sounds plausible to me:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists