linux-kernel - Re: [PATCH] net/phy: tune get_phy_c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150412.204201.2242904202939074517.davem@davemloft.net>
Date:	Sun, 12 Apr 2015 20:42:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Shengzhou.Liu@...escale.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	f.fainelli@...il.com
Subject: Re: [PATCH] net/phy: tune get_phy_c45_ids to support more c45 phy

From: Shengzhou Liu <Shengzhou.Liu@...escale.com>
Date: Fri, 10 Apr 2015 17:10:20 +0800

>  		if ((c45_ids->devices_in_package & 0x1fffffff) == 0x1fffffff) {
> -			*phy_id = 0xffffffff;
> -			return 0;
> +			reg_addr = MII_ADDR_C45 | 0 << 16 | 6;
> +			phy_reg = mdiobus_read(bus, addr, reg_addr);
> +			if (phy_reg < 0)
> +				return -EIO;

Why are you reading this same register again, and why are you doing
it with the magic constant "6".  That's not '6', it's 'MDIO_DEVS2'.

The first loop executed here should have read from this address, and
placed the value into the ->devices_in_package.

> +			c45_ids->devices_in_package = (phy_reg & 0xffff) << 16;
> +			reg_addr = MII_ADDR_C45 | 0 << 16 | 5;

Again, this isn't '5', it's 'MDIO_DEVS1'.

This looks really like a hack.  You're reading again the same registers,
by hand, that the loop should already be reading properly.

Why not restructure the loop to actually probe naturally for the
presence bits in a way that works on the chip you are trying to make
work?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/