linux-kernel - Re: [PATCH 1/2] ide: remove deprecated use of pci api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150413.133903.354139524800441054.davem@davemloft.net>
Date:	Mon, 13 Apr 2015 13:39:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	gnomes@...rguk.ukuu.org.uk, lambert.quentin@...il.com,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] ide: remove deprecated use of pci api

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Mon, 13 Apr 2015 20:23:24 +0300

> On Mon, Apr 13, 2015 at 01:08:13PM -0400, David Miller wrote:
>> From: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
>> Date: Mon, 13 Apr 2015 13:25:30 +0100
>> 
>> > On Thu,  9 Apr 2015 13:46:27 +0200
>> > Quentin Lambert <lambert.quentin@...il.com> wrote:
>> > 
>> >> Replace occurences of the pci api by appropriate call to the dma api.
>> >> 
>> > 
>> > Drivers/ide is obsolete. It probably ought to go at this point but even
>> > so it exists solely in case of a problem or compatibility issue with
>> > drivers/ata. Cleaning it up without testing all the drivers makes no
>> > sense IMHO. Cleaning it up and testing them doesn't make much sense
>> > either.
>> 
>> It's a straightforward transformation, that actually evaluates to what
>> the definitions of the deprecated pci DMA interfaces are defined to.
> 
> Almost, except that it uses GFP_KERNEL instead of GFP_DMA.  But I
> reviewed it and I think it's fine. Quentin sent a GFP_ATOMIC patch as
> the first version and I asked him to redo it.  Maybe I shouldn't have
> done that...

No, I'm fine with that part too, don't worry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/