linux-kernel - RE: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2BD73F@ORSMSX112.amr.corp.intel.com>
Date:	Mon, 13 Apr 2015 17:42:45 +0000
From:	"Moore, Robert" <robert.moore@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Zhaogang Gong <gongzhaogang@...pur.com>
CC:	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"yanxiaofeng@...pur.com" <yanxiaofeng@...pur.com>
Subject: RE: [PATCH] acpica: modify a commit error in file
 drivers/acpi/acpica/nsxfeval.c

Yes, this comes up every now and then.

"iff" means "if and only if" by convention.


> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Monday, April 13, 2015 6:38 AM
> To: Zhaogang Gong
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; lenb@...nel.org; linux-
> acpi@...r.kernel.org; linux-kernel@...r.kernel.org; yanxiaofeng@...pur.com
> Subject: Re: [PATCH] acpica: modify a commit error in file
> drivers/acpi/acpica/nsxfeval.c
> 
> On Monday, April 13, 2015 05:05:07 PM Zhaogang Gong wrote:
> > Change "iff" in function acpi_evaluate_object() to "if".
> >
> > Signed-off-by: Zhaogang Gong <gongzhaogang@...pur.com>
> > ---
> >  drivers/acpi/acpica/nsxfeval.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/acpica/nsxfeval.c
> > b/drivers/acpi/acpica/nsxfeval.c index b6030a2..9571429 100644
> > --- a/drivers/acpi/acpica/nsxfeval.c
> > +++ b/drivers/acpi/acpica/nsxfeval.c
> > @@ -214,7 +214,7 @@ acpi_evaluate_object(acpi_handle handle,
> >  		info->prefix_node = NULL;
> >  	} else if (!handle) {
> >  		/*
> > -		 * A handle is optional iff a fully qualified pathname is
> specified.
> > +		 * A handle is optional if a fully qualified pathname is
> specified.
> 
> This is not a mistake.
> 
> >  		 * Since we've already handled fully qualified names above,
> this is
> >  		 * an error.
> >  		 */
> >
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.