linux-kernel - Re: [PATCH v5 04/10] rbtree: Make lockless searches non-fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150413191011.GJ23123@twins.programming.kicks-ass.net>
Date:	Mon, 13 Apr 2015 21:10:11 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	rusty@...tcorp.com.au, mathieu.desnoyers@...icios.com,
	oleg@...hat.com, paulmck@...ux.vnet.ibm.com,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	andi@...stfloor.org, rostedt@...dmis.org, tglx@...utronix.de,
	laijs@...fujitsu.com, linux@...izon.com,
	David Woodhouse <David.Woodhouse@...el.com>,
	Rik van Riel <riel@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Michel Lespinasse <walken@...gle.com>
Subject: Re: [PATCH v5 04/10] rbtree: Make lockless searches non-fatal

On Mon, Apr 13, 2015 at 05:50:08PM +0200, Ingo Molnar wrote:
> > +static inline void rb_link_node_rcu(struct rb_node * node, struct rb_node * parent,
> > +				    struct rb_node ** rb_link)
> 
> Minor stylistic nit, the standard pattern I suspect has spaces fewer 
> by three:
> 
> static inline void rb_link_node_rcu(struct rb_node *node, struct rb_node *parent,
> 				    struct rb_node **rb_link)

OK, I'll also update the existing code in that file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/