linux-kernel - Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Apr 2015 16:15:05 -0400
From:	Chad Dupuis <chad.dupuis@...gic.com>
To:	Masanari Iida <standby24x7@...il.com>
CC:	<QLogic-Storage-Upstream@...gic.com>, <JBottomley@...allels.com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc_io.c

Looks ok.

Acked-by: Chad Dupuis <chad.dupuis@...gic.com>

On Sun, 12 Apr 2015, Masanari Iida wrote:

> The debug messages in bnx2fc_process_seq_cleanup_compl() doesn't
> match its function name.
>
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index 9ecca85..1b53a68 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1319,7 +1319,7 @@ void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_cmd *seq_clnp_req,
> 	int rc = 0;
> 	struct bnx2fc_rport *tgt = orig_io_req->tgt;
>
> -	BNX2FC_IO_DBG(orig_io_req, "Entered process_cleanup_compl xid = 0x%x"
> +	BNX2FC_IO_DBG(orig_io_req, "Entered process_seq_cleanup_compl xid = 0x%x"
> 			      "cmd_type = %d\n",
> 		   seq_clnp_req->xid, seq_clnp_req->cmd_type);
>
> @@ -1334,7 +1334,7 @@ void bnx2fc_process_seq_cleanup_compl(struct bnx2fc_cmd *seq_clnp_req,
> 	spin_lock_bh(&tgt->tgt_lock);
>
> 	if (rc)
> -		printk(KERN_ERR PFX "clnup_compl: Unable to send SRR"
> +		printk(KERN_ERR PFX "process_seq_clenup_compl: Unable to send SRR"
> 			" IO will abort\n");
> 	seq_clnp_req->cb_arg = NULL;
> 	kref_put(&orig_io_req->refcount, bnx2fc_cmd_release);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/