lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Apr 2015 13:23:25 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Jarod Wilson <jarod@...hat.com> Cc: Alexey Dobriyan <adobriyan@...il.com>, linux-kernel@...r.kernel.org, "Eric W. Biederman" <ebiederm@...ssion.com>, Al Viro <viro@...iv.linux.org.uk>, Miklos Szeredi <miklos@...redi.hu>, Zefan Li <lizefan@...wei.com>, Oleg Nesterov <oleg@...hat.com> Subject: Re: [PATCH try #3] proc: fix PAGE_SIZE limit of /proc/$PID/cmdline On Mon, 13 Apr 2015 14:28:49 -0400 Jarod Wilson <jarod@...hat.com> wrote: > > Well, it's 8 MB at least because of kmalloc and more when it starts > > to vmalloc, so either you increase but keep the limit, or allow > > to pin semi-arbitrary amount of kernel memory IF you want to stay > > with seqfile. My patch requires just 1 page plus whatever g_u_p > > requires. > > Okay, I've tested this out some. Its definitely more user-friendly than > having to require a boot param, and as a bonus, its even more > memory-efficient. Yes, its a bit fugly, but such is life sometimes... > > Though I do wonder if this should perhaps be a helper in mm/util.c like > get_cmdline, maybe replacing get_cmdline or adding an alternative that > gives you everything, rather than an arbitrarily limited length. I only > see one other place actually using get_cmdline so far. > > Tested-by: Jarod Wilson <jarod@...hat.com> > Acked-by: Jarod Wilson <jarod@...hat.com> Thanks, I'll take another look after the 4.0 merge flurry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists