linux-kernel - Re: [PATCH] serial: of-serial: Remove device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552CA1AB.1050608@monstr.eu>
Date:	Tue, 14 Apr 2015 07:12:11 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Peter Hurley <peter@...leysoftware.com>,
	Michal Simek <michal.simek@...inx.com>,
	linux-kernel@...r.kernel.org
CC:	Arnd Bergmann <arnd@...db.de>, stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] serial: of-serial: Remove device_type = "serial" registration

On 04/13/2015 05:50 PM, Peter Hurley wrote:
> [ + Arnd ]
> 
> Hi Michal,
> 
> On 04/13/2015 10:35 AM, Michal Simek wrote:
>> Do not probe all serial drivers by of_serial.c which are using
>> device_type = "serial"; property. Only drivers which have valid
>> compatible strings listed in the driver should be probed.
> 
> What does this fix?
> Is there some kind of probe problem you're trying to address?
> Are you trying to silence the error message?
> 
>> When PORT_UNKNOWN probe will fail anyway.
> 
> Ok, but doesn't device_attach() just continue to try to match other
> drivers on the platform bus?


Please look at my response to Greg reply. Hope that explain it.

Thanks,
Michal








Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)