linux-kernel - Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414080703.GE10964@mwanda>
Date:	Tue, 14 Apr 2015 11:07:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/21] staging: rtl8192e: Fix PREFER_PR_LEVEL warnings

On Mon, Apr 13, 2015 at 11:47:36PM +0200, Mateusz Kulikowski wrote:
> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
> Replace printk() with pr_* where possible.
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib.h            |  4 +-
>  drivers/staging/rtl8192e/rtllib_crypt.c      | 17 ++++----
>  drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 59 +++++++++++-----------------
>  drivers/staging/rtl8192e/rtllib_rx.c         |  4 +-
>  4 files changed, 34 insertions(+), 50 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 472e880..fd7b7a5 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -685,13 +685,13 @@ extern u32 rtllib_debug_level;
>  #define RTLLIB_DEBUG(level, fmt, args...) \
>  do {								\
>  	if (rtllib_debug_level & (level))			\
> -		printk(KERN_DEBUG "rtllib: " fmt, ## args);	\
> +		pr_debug("rtllib: " fmt, ## args);	\
>  } while (0)
>  
>  #define RTLLIB_DEBUG_DATA(level, data, datalen)	\
>  	do {							\
>  		if ((rtllib_debug_level & (level)) == (level)) {	\
> -			printk(KERN_DEBUG "rtllib: %s()\n", __func__);	\
> +			pr_debug("rtllib: %s()\n", __func__);	\
>  			print_hex_dump_bytes(KERN_DEBUG, DUMP_PREFIX_NONE, \
>  					     data, datalen); \
>  		}					\

We've made it slightly more tricky to turn on these debug statements.

I don't think that's a big problem.  I don't think anyone cares about
them.  They are just noise is my guess.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/