linux-kernel - Re: [PATCH] virtio_balloon: drop virtio_balloon_stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414121327.4caacfba.cornelia.huck@de.ibm.com>
Date:	Tue, 14 Apr 2015 12:13:27 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	virtualization@...ts.linux-foundation.org,
	linux-api@...r.kernel.org
Subject: Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern

On Tue, 14 Apr 2015 12:01:13 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> Looks like we are better off sticking with the misaligned stat struct,
> to reduce the amount of virtio 1 specific code in balloon.  So let's do
> it.
> 
> Add a detailed comment to reduce the chance people copy this bad example.
> 
> This also fixes a bug on BE architectures: tag should use
> cpu_to_le16, not cpu_to_le32.
> 
> Acked-by: Cornelia Huck <cornelia.huck@...ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
> 
> Just reposting so it's easier to apply.
> Feel free to squash into previous patch if you think it's
> neater.

+1 for squashing from me. My A-b would also apply to the squashed patch.
> 
>  include/uapi/linux/virtio_balloon.h | 33 +++++++++++++++++++++++++--------
>  drivers/virtio/virtio_balloon.c     | 19 ++++---------------
>  2 files changed, 29 insertions(+), 23 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/