linux-kernel - Re: [RFC PATCH] perf report: Don't add filtered events to histogram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150414124714.GI16027@kernel.org>
Date:	Tue, 14 Apr 2015 09:47:14 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Steve Capper <steve.capper@...aro.org>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [RFC PATCH] perf report: Don't add filtered events to histogram

Em Tue, Apr 14, 2015 at 01:05:03PM +0100, Steve Capper escreveu:
> If one filters events by a single comm in perf report via:
>  perf report --no-children -c program-name
 
This seems right even without any explanation, wonder when was that this
bug was added or what is that we are missing here...

commit 2c86c7ca760634f09dcbd76069e5102b4de6f8f1
Author: Namhyung Kim <namhyung@...nel.org>
Date:   Mon Mar 17 18:18:54 2014 -0300

    perf report: Merge al->filtered with hist_entry->filtered
    
    I.e. don't drop al->filtered entries, create the hist_entries and use
    its ->filtered bitmap, that is kept with the same semantics for its
    bitmap, leaving the filtering to be done at the hist_entry level, i.e.
    in the UIs.
    
    This will allow zooming in/out the filters.
    
    Signed-off-by: Namhyung Kim <namhyung.kim@....com>
    Acked-by: Jiri Olsa <jolsa@...hat.com>
    Cc: Andi Kleen <andi@...stfloor.org>
    Cc: David Ahern <dsahern@...il.com>
    Cc: Ingo Molnar <mingo@...nel.org>
    Cc: Jiri Olsa <jolsa@...hat.com>
    Cc: Namhyung Kim <namhyung.kim@....com>
    Cc: Paul Mackerras <paulus@...ba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
    Link: http://lkml.kernel.org/n/tip-xeyhkepu7plw716lrtb0zlnu@git.kernel.org
    [ yanked this out of a previous patch ]
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index c47bf586fcba..a74059f0c45f 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -231,7 +231,7 @@ static int process_sample_event(struct perf_tool
*tool,
                return -1;
        }
 
-       if (al.filtered || (rep->hide_unresolved && al.sym == NULL))
+       if (rep->hide_unresolved && al.sym == NULL)
                return 0;
 
        if (rep->cpu_list && !test_bit(sample->cpu, rep->cpu_bitmap))

--------------------------------------------------------------

So, yes, what you did was what was there in the first place, but now we
need to try to have the above cset in mind before proceeding...

- Arnaldo


> +++ b/tools/perf/builtin-report.c
> @@ -166,6 +166,9 @@ static int process_sample_event(struct perf_tool *tool,
>  	if (al.map != NULL)
>  		al.map->dso->hit = 1;
>  
> +	if (al.filtered)
> +		return 0;
> +
>  	ret = hist_entry_iter__add(&iter, &al, evsel, sample, rep->max_stack,
>  				   rep);
>  	if (ret < 0)
> -- 
> 2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/