linux-kernel - Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2015 15:27:45 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	bcm-kernel-feedback-list@...adcom.com,
	Thomas Pugliese <thomas.pugliese@...il.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Jonathan Richardson <jonathar@...adcom.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Ray Jui <rjui@...adcom.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Arun Ramamurthy <arun.ramamurthy@...adcom.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	David Mosberger <davidm@...uge.net>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Kevin Hao <haokexin@...il.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Scott Branden <sbranden@...adcom.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Felipe Balbi <balbi@...com>, Tony Prisk <linux@...sktech.co.nz>
Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

On Tue, Apr 14, 2015 at 03:17:30PM +0200, Arnd Bergmann wrote:
> On Tuesday 14 April 2015 14:37:37 Greg Kroah-Hartman wrote:
> > On Tue, Apr 14, 2015 at 01:33:08PM +0200, Arnd Bergmann wrote:
> > > This is true, but all other drivers do the same for GENERIC_PHY at the
> > > moment. If this one gets changed, we should probably apply the same
> > > solution to all current users and fix them consistently.
> > > 
> > > We can do one of these two:
> > > 
> > > a) make sure that the framework has 'static inline' stubs that let you
> > >    build all drivers using it when the framework itself is disabled.
> > 
> > Yes, please do that.
> > 
> > > b) change the drivers using it to 'depends on', and make GENERIC_PHY
> > >    itself a hidden option without a Kconfig prompt.
> > 
> > Then how could GENERIC_PHY ever get set?
> 
> Right now, every driver that provides a phy uses 'select GENERIC_PHY',
> and they would have to keep doing that. This is not unlike what we
> do for other silent symbols like MFD_CORE, REGMAP_I2C, or PINCTRL,
> and it's not as problematic as 'select' on a user-visible option,
> or (worst) mixing 'select' and 'depends on'.

Ok, that would make more sense, but it would be good for the PHY
maintainer to agree to it as well :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/