linux-kernel - Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAS=xmip9WeN2AXH+YpQK9Un1TCaXkHbK-cRFcr3fMcFvrfhPQ@mail.gmail.com>
Date:	Tue, 14 Apr 2015 22:37:34 +0800
From:	Brent Wang <wangbintian@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Bintian <bintian.wang@...wei.com>,
	Mark Rutland <mark.rutland@....com>,
	"dan.zhao@...ilicon.com" <dan.zhao@...ilicon.com>,
	"btw@...l.itp.ac.cn" <btw@...l.itp.ac.cn>,
	Catalin Marinas <catalin.marinas@....com>,
	"wangbinghui@...ilicon.com" <wangbinghui@...ilicon.com>,
	Will Deacon <will.deacon@....com>,
	"huxinwei@...wei.com" <huxinwei@...wei.com>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Haifeng Yan <yanhaifeng@...il.com>,
	Rob Herring <rob.herring@...aro.org>,
	Mike Turquette <mturquette@...aro.org>,
	Xu Wei <xuwei5@...ilicon.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	"sledge.yanwei@...wei.com" <sledge.yanwei@...wei.com>,
	XinWei Kong <kong.kongxinwei@...ilicon.com>,
	"heyunlei@...wei.com" <heyunlei@...wei.com>,
	"w.f@...wei.com" <w.f@...wei.com>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	"z.liuxinliang@...wei.com" <z.liuxinliang@...wei.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kevin Hilman <khilman@...aro.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"puck.chen@...ilicon.com" <puck.chen@...ilicon.com>,
	"xuejiancheng@...wei.com" <xuejiancheng@...wei.com>,
	Rob Herring <robh+dt@...nel.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Tyler Baker <tyler.baker@...aro.org>,
	"zhenwei.wang@...ilicon.com" <zhenwei.wang@...ilicon.com>,
	Guodong Xu <guodong.xu@...aro.org>,
	"victor.lixin@...ilicon.com" <victor.lixin@...ilicon.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Kumar Gala <galak@...eaurora.org>,
	Olof Johansson <olof@...om.net>,
	jorge.ramirez-ortiz@...aro.org,
	"xuyiping@...ilicon.com" <xuyiping@...ilicon.com>,
	"Liguozhu (Kenneth)" <liguozhu@...ilicon.com>
Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for
 hi6220 clock

Hello Arnd,

2015-04-14 21:20 GMT+08:00 Arnd Bergmann <arnd@...db.de>:
> On Tuesday 14 April 2015 20:37:11 Bintian wrote:
>> It's really a smart fix!
>>
>> For the four system controllers, how about change the following strings:
>> +       - "hisilicon,aoctrl"
>> +       - "hisilicon,sysctrl"
>> +       - "hisilicon,mediactrl"
>> +       - "hisilicon,pmctrl"
>>
>> to
>> +       - "hisilicon,hi6220-aoctrl"
>> +       - "hisilicon,hi6220-sysctrl"
>> +       - "hisilicon,hi6220-mediactrl"
>> +       - "hisilicon,hi6220-pmctrl"
>
> Yes, that works.
Thanks, will fix in next version.

>
>> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ?
>
> Seems fine to me, though I'd have to look at the bigger picture to see
> any potential problems. At the moment, I don't see any.
Sure, please also help to review the 6/6 patch of this patch set, many thanks!

BR,

Bintian

>
>         Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/