linux-kernel - Re: I_CLEAR bug while shrinking dcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414144402.GN3107@type.bordeaux.inria.fr>
Date:	Tue, 14 Apr 2015 16:44:02 +0200
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: I_CLEAR bug while shrinking dcache

Al Viro, le Tue 14 Apr 2015 13:44:29 +0100, a écrit :
> On Tue, Apr 14, 2015 at 10:12:54AM +0200, Samuel Thibault wrote:
> > So it seems that shrink_dentry_list was trying to kill an inode which
> > already has I_CLEAR.  I'll be trying the attached patch in the next
> > days.
> 
> That patch is just papering over the problem.

I never said it was a proper fix :)

> The first variant can happen, but in that case it should have had
> DCACHE_DENTRY_KILLED set by said __dentry_kill() and skipped.  The other
> two are clear inode refcounting bugs.
> 
> Do you have a reproducer for that?

It just happened in the middle of the night.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/