linux-kernel - Re: [PATCH] netns: deinline net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429025126.7346.36.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 14 Apr 2015 08:25:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Jiri Pirko <jpirko@...hat.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] netns: deinline net_generic()

On Tue, 2015-04-14 at 17:04 +0200, Denys Vlasenko wrote:
> On 04/14/2015 04:21 PM, Eric Dumazet wrote:
> > On Tue, 2015-04-14 at 15:57 +0200, Denys Vlasenko wrote:
> > 
> >> My allyesconfig, with BUG_ON's commented out:
> >>
> > 
> > Right. But I can tell you nobody uses lockdep on a production kernel.
> > 
> > Here, at Google, we get what I described.
> 
> I'm trying to get to the .config which generates a small function.
> 
> So far, with LOCKDEP off, it is still this big:
> 

If you read exactly what I wrote, you'll understand that at Google,
rcu_read_lock() & rcu_read_unlock() are nop.

Your patch is based on a worst case scenario, and will slow down our use
case.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/