linux-kernel - Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4138287.C3OjQp3FFm@wuerfel>
Date:	Tue, 14 Apr 2015 23:47:35 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Arun Ramamurthy <arun.ramamurthy@...adcom.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	bcm-kernel-feedback-list@...adcom.com,
	Thomas Pugliese <thomas.pugliese@...il.com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Jonathan Richardson <jonathar@...adcom.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Ray Jui <rjui@...adcom.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Dmitry Torokhov <dtor@...gle.com>,
	David Mosberger <davidm@...uge.net>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Kevin Hao <haokexin@...il.com>,
	Paul Bolle <pebolle@...cali.nl>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Scott Branden <sbranden@...adcom.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Felipe Balbi <balbi@...com>, Tony Prisk <linux@...sktech.co.nz>
Subject: Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote:
> >
> > [1] ->
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111
> >
> Kishon,removing select GENERIC_PHY also breaks the builds for certain 
> architectures (i386 and x84_64). Is the consensus to leave the select 
> but make GENERIC_PHY a invisible option? Thanks

I think the best solution is

- make GENERIC_PHY a silent option
- change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so
  it will still work when all other phy drivers are disabled
- change the non-phy drivers that select GENERIC_PHY to either
  use 'depends on' or no explicit dependency in case they are
  still functional without the API. Note that
  drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well,
  not a consumer, despite being outside of drivers/phy.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/