lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2015 16:49:44 +0800 From: Minfei Huang <minfei.huang@...mail.com> To: Miroslav Benes <mbenes@...e.cz> CC: Minfei Huang <mhuang@...hat.com>, Petr Mladek <pmladek@...e.cz>, Josh Poimboeuf <jpoimboe@...hat.com>, sjenning@...hat.com, jkosina@...e.cz, vojtech@...e.cz, live-patching@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] livepatch: Fix the bug if the function name is larger than KSYM_NAME_LEN-1 On 04/15/15 at 10:30P, Miroslav Benes wrote: > On Wed, 15 Apr 2015, Minfei Huang wrote: > > > > Yes, the function name can be changed, before the extra module is > > installed to the production system. > > > > We discuss around and around, there are still some confusion with it. > > > > 1) How does end user know that livepatch can _not_ support the function > > which length is larger than 127. We can not enforce the end user > > to know the livepatch and kallsyms code in detail. > > 2) How does end user use livepatch to patch running extra module, once > > the module is running in the production system, if the function name > > is insane. > > 3) The error message is ambiguity, if we try to patch the overlength > > function. We can give the error message clearly, once the function > > name is overlength. > > > > I think it is better that we can take more time on the people who will > > use livepatch frequently. > > Just my two cents, even if we admit that such change is worth it (and I > am still not convinced that it is the case), I think it would make sense > to fix it somewhere in kallsyms as Josh proposed. I suspect that when > function names longer than KSYM_NAME_LEN were common there would be many > similar problems elsewhere in the kernel. > > That is you can prepare a patch to kallsyms and submit it there. Not sure > who is the maintainer but he might have an opinion about this... > > Thanks, > Miroslav Thanks all who help to review these patches. I will not insist on it, since it may be encountered rarely. Thanks Minfei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists