linux-kernel - Re: [PATCH] of/fdt: fix allocation size for device node path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150415121515.8E1FAC40A0B@trevor.secretlab.ca>
Date:	Wed, 15 Apr 2015 13:15:15 +0100
From:	Grant Likely <grant.likely@...aro.org>
To:	Ricky Liang <jcliang@...omium.org>
Cc:	Ricky Liang <jcliang@...omium.org>,
	Rob Herring <robh+dt@...nel.org>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of/fdt: fix allocation size for device node path

On Tue, 14 Apr 2015 12:36:05 +0800
, Ricky Liang <jcliang@...omium.org>
 wrote:
> The allocation size of device node path is off by one which drops the
> '\0' terminator.
> 
> Signed-off-by: Ricky Liang <jcliang@...omium.org>

This looks like something that should be backported to stable. Do you agree?

g.

> ---
>  drivers/of/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 3a896c9..98a9e6e 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -172,7 +172,7 @@ static void * unflatten_dt_node(void *blob,
>  	if (!pathp)
>  		return mem;
>  
> -	allocl = l++;
> +	allocl = ++l;
>  
>  	/* version 0x10 has a more compact unit name here instead of the full
>  	 * path. we accumulate the full path size using "fpsize", we'll rebuild
> -- 
> 2.1.2
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/