linux-kernel - Re: [PATCH] of/fdt: Remove "reg" data prints from early_init_dt_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLr=0bYWCzTQ7BiFy9+nUWDTSw8sK2yLAK6jdH6fwy-WA@mail.gmail.com>
Date:	Wed, 15 Apr 2015 07:52:12 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH] of/fdt: Remove "reg" data prints from early_init_dt_scan_memory

On Sun, Apr 12, 2015 at 3:16 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> Commit 51975db0b7333 ("of/flattree: merge early_init_dt_scan_memory()
> common code") consolidated some code from PowerPC (typically
> big-endian), and ended-up adding a pr_debug() printing reg properties in
> big-endian (DT native) format, not CPU endian.
>
> This debug print suffers from two problems:
> - we only print 4 "reg" values, while there could be more on typical
>   systems having multiple memory ranges
> - we print these 4 "reg" values in FDT endianess, that is big-endian,
>   and these values could be confusing for little-endian configurations
>
> Since we are already printing the base address and size of the memory
> regions parsed by early_init_dt_scan_memory() later in a way that is
> both endian correct, and takes into account arbitrary number of memory
> banks, just remove that part of the debug print.
>
> Suggested-by: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Patch against devicetree/next

Applied. Thanks.

Rob

>
>  drivers/of/fdt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 3a896c9..34bdc4d 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -879,8 +879,7 @@ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,
>
>         endp = reg + (l / sizeof(__be32));
>
> -       pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n",
> -           uname, l, reg[0], reg[1], reg[2], reg[3]);
> +       pr_debug("memory scan node %s, reg size %d,\n", uname, l);
>
>         while ((endp - reg) >= (dt_root_addr_cells + dt_root_size_cells)) {
>                 u64 base, size;
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/