linux-kernel - Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150415200626.GG4804@codeblueprint.co.uk>
Date:	Wed, 15 Apr 2015 21:06:26 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Roy Franz <roy.franz@...aro.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>, mingo@...hat.com, x86@...nel.org
Subject: Re: [PATCH] x86_64/efi: enforce 32 bit address for command line
 buffer

On Wed, 15 Apr, at 11:56:05AM, Roy Franz wrote:
> Yeah, I guess it shouldn't surprise me that there is support for 64
> bit addresses  there :)
> 
> I'l spin another patch that sets boot_params->ext_cmd_line_ptr with
> the upper 32 bits of the address.
> Should I conditionalize this with #ifdef CONFIG_X86_64, or just do it
> unconditionally, with it being a NOP
> on 32 bit?  (I guess I may end up with an extra cast for the 32 bit case)

Unconditionally is best, I'm loathe to introduce #ifdefs unless
absolutely necessary.

Thanks!

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/