linux-kernel - Re: [PATCH v2] direct-io: only inc/dec inode->i_dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552EE0F9.40607@fb.com>
Date:	Wed, 15 Apr 2015 16:06:49 -0600
From:	Jens Axboe <axboe@...com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	<linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH v2] direct-io: only inc/dec inode->i_dio_count for file
 systems

On 04/15/2015 04:05 PM, Al Viro wrote:
> On Wed, Apr 15, 2015 at 04:01:35PM -0600, Jens Axboe wrote:
>> Hi,
>>
>> A proper patch series posting of the patch to skip inode dio counts
>> where we don't need them. Performance results and general notes in
>> patch #1. We can take this a bit further if we want to push this
>> truncate locking into the caller, but I'd like to keep that as a
>> separate patch series instead.
>>
>> Changes since v2:
>>
>> - Changed flag to DIO_SKIP_DIO_COUNT. Patch 2+3 will use this for
>>    skipping the extra inc/dec for btrfs and ext4, so better rename it
>>    to something that better tells what is happening in the deep mess
>>    that is dio.
>>
>> - Have inode_dio_inc/dec() helpers. Again, this better tells the caller
>>    what is going on.
>
> Please, rebase on vfs.git#for-next; it conflicts (at least) with Omar's
> ->direct_IO() patches, if not with generic_write_checks() ones following
> those.

Sure, I can do that.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/