linux-kernel - Re: [PATCH 1/2] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

date:	Wed, 15 Apr 2015 23:36:09 +0100
from:	"Javier Martinez Canillas" <javier.martinez@...labora.co.uk>
to:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
cc:	linux-kernel@...r.kernel.org, "Nick Dyer" <nick.dyer@...ev.co.uk>,
	"Yufeng Shen" <miletus@...omium.org>,
	"Benson Leung" <bleung@...omium.org>,
	"Daniel Kurtz" <djkurtz@...omium.org>,
	"Sjoerd Simons" <sjoerd.simons@...labora.co.uk>,
	"Olof Johansson" <olof@...om.net>, linux-input@...r.kernel.org
subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

Hello Dmitry,
 
On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov <dmitry.torokhov@...il.com> wrote: 
> On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote:
> > 
> > This is an unrelated cleanup so probably should had been a separate patch?
> 
> Fair enough.
> 
> -- 
> Dmitry
> 
> 
> Input: atmel_mxt_ts - use BIT() macro when reporting button state
> 
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> This makes the intent a tad more clear.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index 0d87ffc..0dcd455 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -726,15 +726,15 @@ static void mxt_input_button(struct mxt_data *data, u8 *message)
>  {
>  	struct input_dev *input = data->input_dev;
>  	const struct mxt_platform_data *pdata = data->pdata;
> -	bool button;
>  	int i;
>  
> -	/* Active-low switch */
>  	for (i = 0; i < pdata->t19_num_keys; i++) {
>  		if (pdata->t19_keymap[i] == KEY_RESERVED)
>  			continue;
> -		button = !(message[1] & (1 << i));
> -		input_report_key(input, pdata->t19_keymap[i], button);
> +
> +		/* Active-low switch */
> +		input_report_key(input, pdata->t19_keymap[i],
> +				 !(message[1] & BIT(i)));
>  	}
>  }
> 

Patch looks good to me,  thanks a lot for splitting the changes
and sorry for the nitpicking.
 
Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/