linux-kernel - Re: [GIT PULL] kdbus for 4.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1504161035570.14032@pobox.suse.cz>
Date:	Thu, 16 Apr 2015 10:43:44 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:	Steven Rostedt <rostedt@...dmis.org>,
	Borislav Petkov <bp@...en8.de>,
	Richard Weinberger <richard@....at>,
	Andy Lutomirski <luto@...capital.net>,
	Al Viro <viro@...iv.linux.org.uk>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Tom Gundersen <teg@...m.no>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Djalal Harouni <tixxdz@...ndz.org>
Subject: Re: [GIT PULL] kdbus for 4.1-rc1

On Wed, 15 Apr 2015, Greg Kroah-Hartman wrote:

> > I originally didn't want to comment on this, but now that you are 
> > making this argument for 3rd or 4th time, I can't really resist. What 
> > exactly are you trying to "prove" by the 13k-lines argument?
> > 
> > mm/vmscan.c is less that 4k lines. Does that sole fact mean that the whole 
> > memory reclaim is trivial to review?
> 
> I'm trying to say that it's not a ton of code.  lines of code are of
> course not a valid way to judge complexity, and I'm not trying to say
> that.  I am trying to point out that it isn't "huge" by comparing it to
> other chunks of code that we all know and love.
> 
> We merge subsystems with new userspace apis that are large than this all
> the time.  I'm trying to say this isn't something "unusual" at all.

I agree with you on that point. Merging 13k lines isn't a big deal, we do 
that all the time.

But I don't think anyone in this (or previous) thread brought up the 
number of lines of kdbus as an unltimate argument for questioning or even 
NACKing it.

So I completely fail to see why this is so relevant that you keep 
repeating it.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/