linux-kernel - Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552F9F9E.3090007@dev.mellanox.co.il>
Date:	Thu, 16 Apr 2015 07:40:14 -0400
From:	Hal Rosenstock <hal@....mellanox.co.il>
To:	"ira.weiny" <ira.weiny@...el.com>
CC:	Michael Wang <yun.wang@...fitbricks.com>,
	Roland Dreier <roland@...nel.org>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tom Tucker <tom@...ngridcomputing.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@...ibm.com>,
	Christoph Raisch <raisch@...ibm.com>,
	Mike Marciniszyn <infinipath@...el.com>,
	Eli Cohen <eli@...lanox.com>,
	Faisal Latif <faisal.latif@...el.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Tom Talpey <tom@...pey.com>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

On 4/15/2015 4:33 PM, ira.weiny wrote:
> On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote:
>> On 4/13/2015 8:22 AM, Michael Wang wrote:
>>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
>>> index 65994a1..d54f91e 100644
>>> --- a/include/rdma/ib_verbs.h
>>> +++ b/include/rdma/ib_verbs.h
>>> @@ -75,10 +75,13 @@ enum rdma_node_type {
>>>  };
>>>  
>>>  enum rdma_transport_type {
>>> +	/* legacy for users */
>>>  	RDMA_TRANSPORT_IB,
>>>  	RDMA_TRANSPORT_IWARP,
>>>  	RDMA_TRANSPORT_USNIC,
>>> -	RDMA_TRANSPORT_USNIC_UDP
>>> +	RDMA_TRANSPORT_USNIC_UDP,
>>> +	/* new transport */
>>> +	RDMA_TRANSPORT_IBOE,
>>>  };
>>>  
>>>  __attribute_const__ enum rdma_transport_type
>>> @@ -1501,6 +1504,8 @@ struct ib_device {
>>>  	int		           (*query_port)(struct ib_device *device,
>>>  						 u8 port_num,
>>>  						 struct ib_port_attr *port_attr);
>>> +	enum rdma_transport_type   (*query_transport)(struct ib_device *device,
>>> +						      u8 port_num);
>>>  	enum rdma_link_layer	   (*get_link_layer)(struct ib_device *device,
>>>  						     u8 port_num);
>>>  	int		           (*query_gid)(struct ib_device *device,
>>
>> libibverbs also exposes transport at the device level. Isn't a change to
>> make transport per port rather than per device needed there as well to
>> be consistent with these proposed kernel changes ? If so, would the
>> additional IBoE transport be exposed ? We also need to worry about
>> backward compatibility for existing applications.
> 
> Early on in this thread we agreed that user space would stay the same until we
> get the kernel straightened out.  

I missed that in this very long thread. I just wanted to be sure that
this will be addressed.

-- Hal

> The above enum and function are not exported
> to user space so I believe this is in alignment with that plan.
> 
> Ira
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/