linux-kernel - Re: [PATCH 2/3 v2] futex: avoid double wake up in futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150416155408.GU27490@worktop.programming.kicks-ass.net>
Date:	Thu, 16 Apr 2015 17:54:08 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Davidlohr Bueso <dave@...olabs.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Darren Hart <darren@...art.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	fredrik.markstrom@...driver.com,
	Manfred Spraul <manfred@...orfullife.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 2/3 v2] futex: avoid double wake up in futex_wake() on -RT

On Thu, Apr 16, 2015 at 07:42:55AM -0700, Davidlohr Bueso wrote:
> On Thu, 2015-04-16 at 12:16 +0200, Peter Zijlstra wrote:
> > But if we decide we want to go do this, I'd propose we reintroduce this
> > delayed wake list thing again.
> 
> Given that futexes aren't the only potential users, I definitely agree.
> Lemme cleanup the patches and I'll resend. Now, one thing I wonder about
> is if we should bother making it a delayed list a plist instead -- as
> not all users would consider rt-tasks like futexes do.

plist don't work and should not be used for tasks anymore. I suppose I
should go rip them out of futexes too. If you want to make the thing
priority aware we should probably abstract the rb-tree from rtmutex.c


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/