linux-kernel - Re: [PATCH 0/7] selftests: fixes for installation and cross compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1429157287.3464.0.camel@ellerman.id.au>
Date:	Thu, 16 Apr 2015 14:08:07 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Tyler Baker <tyler.baker@...aro.org>
Cc:	Shuah Khan <shuahkh@....samsung.com>,
	Kevin Hilman <khilman@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Darren Hart <dvhart@...radead.org>,
	David Herrmann <dh.herrmann@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/7] selftests: fixes for installation and cross
 compilation

On Tue, 2015-04-14 at 15:50 -0700, Tyler Baker wrote:
> This patch set fixes various issues observed when cross building and 
> installing selftests.
> 
> As I began investigating improving the test output format, I performed an 
> audit of the current tests to ensure all tests were able to execute on various 
> target architectures. I found that some tests did not install their binaries 
> and others required directories to be installed to execute properly. There 
> were also cases in which tests were being installed when they were never built.
> With this series applied all tests compile when appropriate and install their 
> output properly.
> 
> I have tested this series by building, installing and deploying all selftests 
> to x86, arm and arm64 targets. 
> 
> This series is based on next-20150414
> 
> Tyler Baker (7):
>   selftests: copy TEST_DIRS to INSTALL_PATH
>   selftests/ftrace: install test.d
>   selftests/breakpoints: emit skip and omit installation when tests are
>     not compiled
>   selftests/kdbus: install kdbus-test
>   selftests/x86: fix cross build logic
>   selftests/x86: install tests
>   selftests/exec: do not install subdir as it is already created

This series looks good except for 5/7.

As Andy says you should just cause all to have no dependencies for !x86.

Otherwise-acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/