linux-kernel - RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC2508@ORSMSX109.amr.corp.intel.com>
Date:	Thu, 16 Apr 2015 17:30:34 +0000
From:	"Hefty, Sean" <sean.hefty@...el.com>
To:	Tom Talpey <tom@...pey.com>,
	Michael Wang <yun.wang@...fitbricks.com>,
	"Hal Rosenstock" <hal@....mellanox.co.il>
CC:	Roland Dreier <roland@...nel.org>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tom Tucker <tom@...ngridcomputing.com>,
	"Steve Wise" <swise@...ngridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@...ibm.com>,
	Christoph Raisch <raisch@...ibm.com>,
	infinipath <infinipath@...el.com>,
	"Eli Cohen" <eli@...lanox.com>,
	"Latif, Faisal" <faisal.latif@...el.com>,
	"Jack Morgenstein" <jackm@....mellanox.co.il>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	"Weiny, Ira" <ira.weiny@...el.com>,
	"Jason Gunthorpe" <jgunthorpe@...idianresearch.com>,
	Doug Ledford <dledford@...hat.com>
Subject: RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core
 cma/ucm

> > To be confirmed:
> > 				PORT ASSIGNED
> > 	rdma_init_qp_attr	Y
> > 	rdma_destroy_id		unknown
> > 	cma_listen_on_dev	N
> > 	cma_bind_loopback	N

Bind loopback will attach to a port, but the id does not have on entry.

> > 	rdma_listen		N
> 
> Why "N"? rdma_listen() can be constrained to a single port, right?
> And even if wildcarded, it needs to act on multiple ports, which is
> to say, it will fail only if no ports are eligible.

Rdma listen should be unknown.  The id may be assigned to a port.  It depends on the source address.

> > 	rdma_connect		Y
> > 	rdma_accept		Y
> > 	rdma_reject		Y
> > 	rdma_disconnect		Y
> > 	ib_ucm_add_one		N

Others look correct.

Btw, thanks for your work on this.  I know this is becoming a much bigger change than you originally intended.  :)

- Sean