linux-kernel - Re: [PATCH] x86/fpu: Load xsave pointer *after* initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552FFC19.8030007@redhat.com>
Date:	Thu, 16 Apr 2015 14:14:49 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...nel.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tavis Ormandy <taviso@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/fpu: Load xsave pointer *after* initialization

On 04/16/2015 02:05 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> So I was playing with gdb today and did this simple thing:
> 
> gdb /bin/ls
> 
> ...
> 
> (gdb) run
> 
> Box exploded with the splat at the end because we do cache
> &target->thread.fpu.state->xsave into the local variable xsave but
> that pointer is NULL at that time and it gets initialized later, in
> init_fpu(), see

> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Rik van Riel <riel@...hat.com>
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Tavis Ormandy <taviso@...gle.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>

Reviewed-by: Rik van Riel <riel@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/