linux-kernel - Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150417103356.6ce78145@bbrezillon>
Date:	Fri, 17 Apr 2015 10:33:56 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Jason Cooper <jason@...edaemon.net>
Cc:	Arnaud Ebalard <arno@...isbad.org>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Mark Rutland <mark.rutland@....com>,
	Thomas Petazzoni <info@...e-electrons.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Eran Ben-Avi <benavi@...vell.com>,
	Nadav Haklai <nadavh@...vell.com>, devicetree@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
	linux-crypto@...r.kernel.org, Kumar Gala <galak@...eaurora.org>,
	Tawfik Bayouk <tawfik@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Lior Amsalem <alior@...vell.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hi Jason,

On Mon, 13 Apr 2015 20:11:46 +0000
Jason Cooper <jason@...edaemon.net> wrote:

> > 
> > > I'd appreciate if we'd look into it.  I understand from on-list and
> > > off-list discussion that the rewrite was unavoidable.  So I'm willing to
> > > concede that.  Giving people time to migrate from old to new while still
> > > being able to update for other security fixes seems reasonable.
> > 
> > Jason, what do you think of the approach above? 
> 
> I say keep it simple.  We shouldn't use the DT changes to trigger one
> vice the other.  We need to be able to build both, but only load one at
> a time.  If that's anything other than simple to do, then we make it a
> Kconfig binary choice and move on.

Actually I was planning to handle it with a Kconfig dependency rule
(NEW_DRIVER depends on !OLD_DRIVER and OLD_DRIVER depends
on !NEW_DRIVER).
I don't know how to make it a runtime check without adding new
compatible strings for the kirkwood, dove and orion platforms, and I'm
sure sure this is a good idea.
Do you have any ideas ?

Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/