lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Apr 2015 11:12:13 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Ulf Hansson <ulf.hansson@...aro.org> Cc: Chaotian Jing <chaotian.jing@...iatek.com>, Mark Rutland <mark.rutland@....com>, James Liao <jamesjj.liao@...iatek.com>, Arnd Bergmann <arnd@...db.de>, srv_heupstream@...iatek.com, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Hongzhou Yang <hongzhou.yang@...iatek.com>, Catalin Marinas <catalin.marinas@....com>, bin.zhang@...iatek.com, linux-mmc <linux-mmc@...r.kernel.org>, Chris Ball <chris@...ntf.net>, Will Deacon <will.deacon@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, linux-mediatek@...ts.infradead.org, Sascha Hauer <kernel@...gutronix.de>, Matthias Brugger <matthias.bgg@...il.com>, "Joe.C" <yingjoe.chen@...iatek.com>, Eddie Huang <eddie.huang@...iatek.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 2/5] mmc: mediatek: Add Mediatek MMC driver Ulf, On Tue, Mar 31, 2015 at 02:23:06PM +0200, Ulf Hansson wrote: > On 17 March 2015 at 04:13, Chaotian Jing <chaotian.jing@...iatek.com> wrote: > > + > > + msdc_set_buswidth(host, ios->bus_width); > > + > > + /* Suspend/Resume will do power off/on */ > > + switch (ios->power_mode) { > > + case MMC_POWER_UP: > > + msdc_init_hw(host); > > + if (!IS_ERR(mmc->supply.vmmc)) { > > + ret = mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, > > + ios->vdd); > > + if (ret) { > > + dev_err(host->dev, "Failed to set vmmc power!\n"); > > + return; > > + } > > + } > > + break; > > + case MMC_POWER_ON: > > + if (!IS_ERR(mmc->supply.vqmmc)) { > > + ret = regulator_enable(mmc->supply.vqmmc); > > The calls to regulator_enable|disable() for the vqmmc will not be > balanced properly here. You need a local cache variable like > "is_enabled" to keep track of this. Shouldn't the MMC core provide balanced hooks for this? What about MMC_POWER_UP, can this be used for enabling regulators? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists