linux-kernel - Re: [PATCH v2] rcu: small rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150417104130.0f99fe4c@gandalf.local.home>
Date:	Fri, 17 Apr 2015 10:41:30 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Milos Vyletel <milos@...hat.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Josh Triplett <josh@...htriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org (open list:READ-COPY UPDATE...),
	linux-doc@...r.kernel.org (open list:DOCUMENTATION),
	jeff.haran@...rix.com
Subject: Re: [PATCH v2] rcu: small rcu_dereference doc update

On Fri, 17 Apr 2015 16:38:04 +0200
Milos Vyletel <milos@...hat.com> wrote:

> Make a note stating that repeated calls of rcu_dereference() may not
> return the same pointer if update happens while in critical section.
> 
> Reported-by: Jeff Haran <jeff.haran@...rix.com>
> Signed-off-by: Milos Vyletel <milos@...hat.com>

Reviewed-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> ---
>  Documentation/RCU/whatisRCU.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/whatisRCU.txt b/Documentation/RCU/whatisRCU.txt
> index 88dfce1..16622c9 100644
> --- a/Documentation/RCU/whatisRCU.txt
> +++ b/Documentation/RCU/whatisRCU.txt
> @@ -256,7 +256,9 @@ rcu_dereference()
>  	If you are going to be fetching multiple fields from the
>  	RCU-protected structure, using the local variable is of
>  	course preferred.  Repeated rcu_dereference() calls look
> -	ugly and incur unnecessary overhead on Alpha CPUs.
> +	ugly, do not guarantee that the same pointer will be returned
> +	if an update happened while in the critical section, and incur
> +	unnecessary overhead on Alpha CPUs.
>  
>  	Note that the value returned by rcu_dereference() is valid
>  	only within the enclosing RCU read-side critical section.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/