linux-kernel - Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420162700.3e69c7db@notabene.brown>
Date:	Mon, 20 Apr 2015 16:27:00 +1000
From:	NeilBrown <neilb@...e.de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	David Howells <dhowells@...hat.com>, Chris Mason <clm@...com>,
	Al Viro <viro@...IV.linux.org.uk>, Josef Bacik <jbacik@...com>,
	David Sterba <dsterba@...e.cz>, linux-cachefs@...r.kernel.org,
	Dave Chinner <david@...morbit.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA
 instead of ->bmap.

On Sun, 19 Apr 2015 23:08:18 -0700 Christoph Hellwig <hch@...radead.org>
wrote:

> Please just usse SEEK_HOLE/DATA support unconditioanlly.  ->bmap is a
> horrible hack that is completely unsafe.
> 

A worthwhile goal, but I certainly wouldn't consider pursuing it until what I
have submitted so far as been accepted - let's not reject "good" while
waiting for "perfect".

NeilBrown

Content of type "application/pgp-signature" skipped