linux-kernel - Re: [patch for 4.0] x86: silence warning in /dev/mem support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420065235.GA13876@gmail.com>
Date:	Mon, 20 Apr 2015 08:52:35 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Pavel Machek <pavel@....cz>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	jgross@...e.com, roland@...estorage.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch for 4.0] x86: silence warning in /dev/mem support


* Pavel Machek <pavel@....cz> wrote:

> Hi!
> 
> > >   CC      arch/x86/mm/ioremap.o
> > >   arch/x86/mm/ioremap.c: In function ‘xlate_dev_mem_ptr’:
> > >   arch/x86/mm/ioremap.c:363:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > >      addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
> > >                ^
> > >   LD      arch/x86/mm/built-in.o
> > > 		 
> > > pavel@amd:/data/l/linux$ gcc --version
> > > gcc (Debian 4.9.2-10) 4.9.2
> > 
> > So this code has not been changed for a year or so in theory, and I've 
> > never seen this warning with GCC 4.9.1. I'm wondering how it 
> > triggered. Could you send me your .config that triggers this?
> 
> Config sent in private email. 32-bit kernel.

Ah, I see, the key is:

  CONFIG_HIGHMEM64G=y

and neither x86 defconfig nor allyesconfig/allmodconfig selects 
HIGHMEM64G apparently, so this was rarely triggered.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/