linux-kernel - Re: [PATCH] Staging: i2o: fixed various code style issues in i2o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420080209.GR10964@mwanda>
Date:	Mon, 20 Apr 2015 11:02:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Yorick Rommers <yorick-rommers@...mail.com>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	helen.fornazier@...il.com, iskaranth@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: i2o: fixed various code style issues in
 i2o_block.c

On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote:
> From: Yorick <yorick-rommers@...mail.com>

Don't include a From: unless you are sending a patch someone else wrote.
Otherwise we prefer to get it from your email From.  Also you forgot
your last name.

> @@ -488,8 +488,8 @@ static int i2o_block_reply(struct i2o_controller *c, u32 m,
>  		 *      Don't stick a supertrak100 into cache aggressive modes
>  		 */
>  
> -		osm_err("TID %03x error status: 0x%02x, detailed status: "
> -			"0x%04x\n", (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
> +		osm_err("TID %03x error status: 0x%02x, detailed status: 0x%04x\n",
> +      (le32_to_cpu(msg->u.head[1]) >> 12 & 0xfff),
>  			status >> 24, status & 0xffff);

The new indenting is wrong.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/