| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Apr 2015 11:27:46 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Yorick Rommers <yorick-rommers@...mail.com> Cc: joe@...ches.com, devel@...verdev.osuosl.org, lidza.louina@...il.com, driverdev-devel@...uxdriverproject.org, linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org Subject: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences. On Sun, Apr 19, 2015 at 11:58:53PM +0200, Yorick Rommers wrote: > Hello Joe, > > Thank you once again for the feedback. > I've changed my patch accordingly, see below. > > -------------------------------------- The patch is nice except for this chunk. And also you should be putting version numbers in the patch description: [PATCH v4] Staging: dgnc: Using temporary variable to save space > > A patch for a line being too long (>80) in dgnc_mgmt.c, > fixed by making a temporary value for dgnc_Board[brd], > replacing all instanced of dgnc_Board[brd] with temporary value, > and removing unnecessary typecasts. > > Signed-off-by: Yorick Rommers <yorick-rommers@...mail.com> > --- And put a note under the cut off here. --- v4: Removed email to Joe Perches from the patch description regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists