linux-kernel - Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3914.1429528902@warthog.procyon.org.uk>
Date:	Mon, 20 Apr 2015 12:21:42 +0100
From:	David Howells <dhowells@...hat.com>
To:	NeilBrown <neilb@...e.de>
Cc:	dhowells@...hat.com, Chris Mason <clm@...com>,
	Al Viro <viro@...IV.linux.org.uk>, Josef Bacik <jbacik@...com>,
	David Sterba <dsterba@...e.cz>, linux-cachefs@...r.kernel.org,
	Dave Chinner <david@...morbit.com>,
	linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap.

NeilBrown <neilb@...e.de> wrote:

> @@ -721,24 +733,45 @@ int cachefiles_read_or_alloc_pages(struct fscache_retrieval *op,

We can actually do better than this what you've done here for
cachefiles_read_or_alloc_pages().  We can use SEEK_DATA to check the beginning
of a run of pages and then SEEK_HOLE to see how many pages are covered.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/