linux-kernel - Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420121020.GB8483@danjae.kornet>
Date:	Mon, 20 Apr 2015 21:10:20 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct
 hist_entry_tui

Hi Jiri,

On Mon, Apr 20, 2015 at 10:20:02AM +0200, Jiri Olsa wrote:
> On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote:
> > Since perf diff only support stdio output, TUI fields are only accessed
> > from perf report (or perf top).  So add new struct hist_entry_tui and
> > move those fields into them.  And include it as an union member.
> > 
> 
> SNIP
> 
> >  
> > -	/* XXX These two should move to some tree widget lib */
> > -	u16			row_offset;
> > -	u16			nr_rows;
> > -
> >  	bool			init_have_children;
> >  	char			level;
> >  	u8			filtered;
> > +	union {
> > +		struct hist_entry_diff	diff;
> > +		struct hist_entry_tui	tui;
> > +	};
> 
> could you please add the comment from changelog in here,
> so it's easy to figure this out in the future 

OK, will do.

Thanks,
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/