linux-kernel - Re: [PATCH 6/7] perf hists browser: Split popup menu actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Apr 2015 21:21:37 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 6/7] perf hists browser: Split popup menu actions

On Mon, Apr 20, 2015 at 11:21:59AM +0200, Jiri Olsa wrote:
> On Sun, Apr 19, 2015 at 01:04:14PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > +
> > +static int
> > +add_script_opt(struct popup_option *opt, char **optstr,
> > +	       struct hist_browser *browser __maybe_unused,
> > +	       struct thread *thread, struct symbol *sym)
> > +{
> > +	if (thread) {
> > +		if (asprintf(optstr, "Run scripts for samples of thread [%s]",
> > +			     thread__comm_str(thread)) < 0)
> > +			return 0;
> > +	} else if (sym) {
> 
> there's also check for sym->namelen in the original code

Ah, right.  I'll change it.

But I wonder there's a case 'sym && !sym->namelen' though..

Thanks,
Namhyung


> 
> > +		if (asprintf(optstr, "Run scripts for samples of symbol [%s]",
> > +			     sym->name) < 0)
> > +			return 0;
> > +	} else {
> > +		if (asprintf(optstr, "Run scripts for all samples") < 0)
> > +			return 0;
> > +	}
> > +
> > +	opt->thread = thread;
> > +	opt->sym = sym;
> > +	opt->fn = do_run_script;
> > +
> > +	return 1;
> > +}
> 
> SNIP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/