[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150420155648.GA7676@obsidianresearch.com>
Date: Mon, 20 Apr 2015 09:56:48 -0600
From: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Russell King - ARM Linux <linux@....linux.org.uk>,
Jens Wiklander <jens.wiklander@...aro.org>,
valentin.manea@...wei.com, devicetree@...r.kernel.org,
javier@...igon.com, emmanuel.michel@...com,
Herbert Xu <herbert@...dor.apana.org.au>,
Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
jean-michel.delorme@...com, tpmdd-devel@...ts.sourceforge.net,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [tpmdd-devel] [RFC PATCH 1/2] tee: generic TEE subsystem
On Mon, Apr 20, 2015 at 04:54:32PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 19, 2015 at 11:08:00PM -0600, Jason Gunthorpe wrote:
> > I still suspect the expected way to write a new mid layer is to create
> > your own struct device and not rely on misc_device,
>
> Yes, that is the way. You can not use misc_device for anything other
> than creating the char node that your driver can use through the fileops
> you pass to it.
>
> Do not use a misc_device to create sysfs files for, or anything else, it
> will be wrong and racy, as you have pointed out.
Thanks!
Can you quickly comment on when a misc device should be used compared to
alloc_chrdev_region & cdev_add ?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists