linux-kernel - RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1504201336511.1321-100000@iolanthe.rowland.org>
Date:	Mon, 20 Apr 2015 13:38:58 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH 2/9][v2]usb:fsl:otg: Add support to add/remove usb host
 driver

On Mon, 20 Apr 2015, Ramneek Mehresh wrote:

> > > This is the wrong way to connect platform-private data with the
> > > ehci_hcd structure.  The right way is to use an ehci_driver_overrides
> > > structure, like in ehci-omap.c and quite a few other EHCI platform drivers.
> > >
> >
> Hi Alan, I checked again...we are not connecting ehci_hcd structure here with 
> platform-private data. We are just having a wrapper on it to have some additional 
> Information that can be used for ehci fsl driver. This additional information is 
> private to ehci fsl driver, and is mainly used for otg driver functionality and to
> save/restore fsl regsiters during deep-sleep 

It doesn't matter -- private data is private data, whether it is
platform-private or driver-private.

Either way, you can't wrap ehci-hcd in anything.  The private data has
to added to the end, the way ehci-omap.c does it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/