linux-kernel - Re: [PATCH 13/49] writeback: move bandwidth related fields from backing_dev_info into bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150420180120.GC4206@htj.duckdns.org>
Date:	Mon, 20 Apr 2015 14:01:20 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Jan Kara <jack@...e.cz>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org, hch@...radead.org,
	hannes@...xchg.org, linux-fsdevel@...r.kernel.org,
	vgoyal@...hat.com, lizefan@...wei.com, cgroups@...r.kernel.org,
	linux-mm@...ck.org, mhocko@...e.cz, clm@...com,
	fengguang.wu@...el.com, david@...morbit.com, gthelen@...gle.com,
	Jaegeuk Kim <jaegeuk@...nel.org>,
	Steven Whitehouse <swhiteho@...hat.com>
Subject: Re: [PATCH 13/49] writeback: move bandwidth related fields from
 backing_dev_info into bdi_writeback

On Mon, Apr 20, 2015 at 05:09:50PM +0200, Jan Kara wrote:
> On Mon 06-04-15 15:58:02, Tejun Heo wrote:
> > Currently, a bdi (backing_dev_info) embeds single wb (bdi_writeback)
> > and the role of the separation is unclear.  For cgroup support for
> > writeback IOs, a bdi will be updated to host multiple wb's where each
> > wb serves writeback IOs of a different cgroup on the bdi.  To achieve
> > that, a wb should carry all states necessary for servicing writeback
> > IOs for a cgroup independently.
> > 
> > This patch moves bandwidth related fields from backing_dev_info into
> > bdi_writeback.
> > 
> > * The moved fields are: bw_time_stamp, dirtied_stamp, written_stamp,
> >   write_bandwidth, avg_write_bandwidth, dirty_ratelimit,
> >   balanced_dirty_ratelimit, completions and dirty_exceeded.
> > 
> > * writeback_chunk_size() and over_bgroup_thresh() now take @wb instead
> >   of @bdi.
>  				^^^ over_bground_thresh()
> 
> Otherwise the patch looks good to me. You can add:

Updated accordingly.

> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/